Skip to content

feat(command): submit PR time via @holdex bot#113

Merged
zolotokrylin merged 2 commits into
mainfrom
feat/submit-time-command
May 14, 2026
Merged

feat(command): submit PR time via @holdex bot#113
zolotokrylin merged 2 commits into
mainfrom
feat/submit-time-command

Conversation

@zolotokrylin
Copy link
Copy Markdown
Member

@zolotokrylin zolotokrylin commented May 14, 2026

Adds a global /submit-time Claude Code command that posts @holdex pr submit-time <time> on the current PR.

Summary by CodeRabbit

  • Documentation
    • Added user instructions for the submit-time command: how to provide time arguments (accepted formats like 15m, 1h, 2h30m, 1.5h), prompting/validation behavior, how the target pull request is resolved when not explicit, and confirmation that a time-posting comment is posted with the PR link.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Walkthrough

Adds documentation for a new submit-time command describing accepted time formats, argument prompting/validation, PR resolution via current branch or fallback prompt using gh pr list, posting the @holdex pr submit-time comment with gh pr comment, and showing the PR URL confirmation.

Changes

submit-time command documentation

Layer / File(s) Summary
Command documentation
.claude/commands/submit-time.md
Documents the submit-time command usage, input handling via $ARGUMENTS, accepted time format validation (15m, 1h, 2h30m, 1.5h), PR resolution workflow (git worktree detection, gh pr list lookup, fallback prompt), comment posting via gh pr comment, and confirmation output including PR URL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • markholdex
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a command to submit PR time via the @holdex bot.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/submit-time-command

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@holdex
Copy link
Copy Markdown

holdex Bot commented May 14, 2026

Time Submission Status

Member Status Time Action Last Update
zolotokrylin ✅ Submitted 11min Update time May 14, 2026, 7:38 AM

You can submit time with the command. Example:

@holdex pr submit-time 15m

See available commands to help comply with our Guidelines.

@zolotokrylin zolotokrylin requested a review from markholdex May 14, 2026 02:56
@zolotokrylin
Copy link
Copy Markdown
Member Author

@holdex pr submit-time 11m

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/commands/submit-time.md:
- Around line 23-27: The command uses an undefined <owner/repo> and
unnecessarily requires a PR number; instead take the PR `url` from the JSON
produced earlier (the `url` field referenced on line 16) and call gh pr comment
with that URL: replace the current gh pr comment <number> --repo <owner/repo>
--body "@holdex pr submit-time $ARGUMENTS" invocation with gh pr comment
<PR_URL> --body "@holdex pr submit-time $ARGUMENTS", then confirm the comment
posted and display the PR URL.
🪄 Autofix (Beta)

✅ Autofix completed


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0bfbdc0f-1932-4e67-9a2a-9d3ebc5ee997

📥 Commits

Reviewing files that changed from the base of the PR and between fbde9e2 and 37438fe.

📒 Files selected for processing (1)
  • .claude/commands/submit-time.md

Comment thread .claude/commands/submit-time.md
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Fixes Applied Successfully

Fixed 1 file(s) based on 1 unresolved review comment.

Files modified:

  • .claude/commands/submit-time.md

Commit: fcb1c94f39e4dc6361848a5bedd8bc2635e9313c

The changes have been pushed to the feat/submit-time-command branch.

Time taken: 2m 13s

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
.claude/commands/submit-time.md (1)

16-24: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add instructions for extracting the URL from JSON.

The JSON output on line 16 includes a url field, but there's no instruction on how to extract it before using <PR_URL> on line 24.

📝 Add extraction step
 gh pr list --head "$(git branch --show-current)" --json number,url,title --limit 1

+Extract the url field from the JSON output above.
+
If no PR is found for the current branch, ask the user for the PR number or URL.

Post the comment


</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/commands/submit-time.md around lines 16 - 24, The gh pr list command
returns JSON including a url field but the script never extracts it; update the
flow so after running gh pr list --json number,url,title you extract the first
result's url (for example using gh's --jq to select .[0].url or piping the JSON
to jq and selecting .[0].url) and save that value as PR_URL, then pass that
PR_URL into gh pr comment; reference the gh pr list invocation and the gh pr
comment step when making this change.


</details>

</blockquote></details>

</blockquote></details>

<details>
<summary>🤖 Prompt for all review comments with AI agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In @.claude/commands/submit-time.md:

  • Around line 16-24: The gh pr list command returns JSON including a url field
    but the script never extracts it; update the flow so after running gh pr list
    --json number,url,title you extract the first result's url (for example using
    gh's --jq to select .[0].url or piping the JSON to jq and selecting .[0].url)
    and save that value as PR_URL, then pass that PR_URL into gh pr comment;
    reference the gh pr list invocation and the gh pr comment step when making this
    change.

</details>

---

<details>
<summary>ℹ️ Review info</summary>

<details>
<summary>⚙️ Run configuration</summary>

**Configuration used**: Organization UI

**Review profile**: CHILL

**Plan**: Pro

**Run ID**: `8ae0ef50-dcba-4217-ab31-04d05b199ec8`

</details>

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 37438fe829d15f15bb5023472f80d989b8a8a835 and fcb1c94f39e4dc6361848a5bedd8bc2635e9313c.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `.claude/commands/submit-time.md`

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@zolotokrylin zolotokrylin merged commit bebeb3c into main May 14, 2026
3 checks passed
@zolotokrylin zolotokrylin deleted the feat/submit-time-command branch May 14, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant